AZURE TF Check - CKV_AZURE_136 #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Feb 3, 2022
checkov/terraform/checks/resource/azure/PostgreSQLFlexiServerGeoBackupEnabled.py
Outdated
Show resolved
Hide resolved
| from checkov.common.models.enums import CheckResult | ||
|
|
||
|
|
||
| class TestPostgreSQLFlexiServerGeoBackupEnabled(unittest.TestCase): |
There was a problem hiding this comment.
please adjust the tests, so they scan real terraform code, like here #2304
Aaditya-Nandeshwar
changed the title
Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
gruebel
approved these changes
Feb 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Added check for georedundant PostgreSQLFlexiServer * Added test for GeoRedundant PostgreSQLFlexiServer * Added check for GeoRedundant PostgreSQLFlexiServer * Corrected ClassName * Apply suggestions from code review Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> * Added tests for real terraform code Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Co-authored-by: Aaditya Nandeshwar <aaditya.nandeshwar@cldcvr.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Added check for georedundant PostgreSQLFlexiServer * Added test for GeoRedundant PostgreSQLFlexiServer * Added check for GeoRedundant PostgreSQLFlexiServer * Corrected ClassName * Apply suggestions from code review Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> * Added tests for real terraform code Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Co-authored-by: Aaditya Nandeshwar <aaditya.nandeshwar@cldcvr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Implementing check for Azure PostgreSQL FlexiServer GeoBackup Enabled in terraform.
Terraform Docs:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/postgresql_flexible_server
Note:
If we have not pass the "geo_redundant_backup_enabled" argument in terraform then the check fails, as by default it will not provide backup facility.
If we have pass the "geo_redundant_backup_enabled" argument in terraform with value "false" in terraform template then the check fails, means we have turned off the backup facility.
If we have pass the "geo_redundant_backup_enabled" argument in terraform with value "true" in terraform template then the check passed, means we have turned on the backup facility.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.